Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Release 1.25.2 #3615

Merged
merged 11 commits into from
May 26, 2022
Merged

Release 1.25.2 #3615

merged 11 commits into from
May 26, 2022

Conversation

kingdonb
Copy link
Member

@kingdonb kingdonb commented May 26, 2022

Kingdon Barrett and others added 11 commits May 3, 2022 15:29
Housekeeping: merge release branch 1.25.x into master
This is retro-compatible with previous versions (won't cause a new deployment without specifically setting the config)
It allows a user to set the `--git-verify-signatures-mode` option instead of the deprecated `--git-verify-signatures` which is currently always set

Signed-off-by: Julien Duchesne <[email protected]>
Signed-off-by: Kingdon Barrett <[email protected]>
…s-to-mode

Add access to `--git-verify-signatures-mode` from Helm
Signed-off-by: Kingdon Barrett <[email protected]>
Signed-off-by: Kingdon Barrett <[email protected]>
This was disabled by default at openssh 8.8 but is still used by some
git implementations eg Azure DevOps

Signed-off-by: David Hotham <[email protected]>
Allow RSA signatures using SHA-1 hash algorithm
Signed-off-by: Kingdon Barrett <[email protected]>
Signed-off-by: Kingdon Barrett <[email protected]>
@kingdonb kingdonb requested a review from pjbgf May 26, 2022 13:05
@kingdonb
Copy link
Member Author

When reviewing, changes before 9615263 can be disregarded as they have already been reviewed in master.

(The only commit with relevant changes to review is here: 5b93d3c)

I'm intending on fast-tracking a release for this to avoid inconveniencing anyone else who has upgraded, as soon as I get a confirmation in #3611 that it solves the issue from the prerelease build, or as soon as CI passes. (1.25.2 should likely be out today.)

@dimbleby
Copy link
Contributor

will there be a 1.13.1 chart too? Not a big deal either way for me, just asking!

@kingdonb kingdonb mentioned this pull request May 26, 2022
@kingdonb
Copy link
Member Author

@dimbleby You betcha: see #3616

I will need a couple of sign-offs from at least one other maintainer to publish the full release including a chart, that is the major release bottleneck for Flux v1 besides actually composing these PRs.

It has been a big relief to have helpful outside contributors who can report and confirm such issues that may be from weird external dependencies and send a PR to get it fixed. Thanks very much for your contribution here.

I have internalized the release process pretty well now to the point that it takes less than 2 hours from end to end for me to put out a release 👍 the hard part is setting up the repro environment and isolating the actual fix.

@dimbleby
Copy link
Contributor

Super - and thank you so much for jumping on this so quickly

@kingdonb
Copy link
Member Author

kingdonb commented May 26, 2022

Since this fix came from an external contributor, according to the policies for this repo I am able to approve and merge the PR for prerelease and again for release without any secondary approvals. I cannot publish the chart before I get those approvals though. If this is a high priority for you and you need the chart, please let me know and I will follow up then.

It should all be ready early next week anyway, if that's soon enough 👍

@kingdonb kingdonb merged commit 710825f into release/1.25.x May 26, 2022
kingdonb pushed a commit to kingdonb/tailscale-k8s that referenced this pull request May 26, 2022
kingdonb pushed a commit to kingdonb/tailscale-k8s that referenced this pull request May 26, 2022
for fluxcd/flux#3616,
fluxcd/flux#3615

* add a bunch of excludes to helmrelease for flux v1
* kustomize resource is not relevant for flux v1

The old kustomize should not be used as it is unsafe

* flux should not scan for kindest images either
* fixup index.docker.io

Signed-off-by: Kingdon Barrett <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants