-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Conversation
Housekeeping: merge release branch 1.25.x into master
This is retro-compatible with previous versions (won't cause a new deployment without specifically setting the config) It allows a user to set the `--git-verify-signatures-mode` option instead of the deprecated `--git-verify-signatures` which is currently always set Signed-off-by: Julien Duchesne <[email protected]> Signed-off-by: Kingdon Barrett <[email protected]>
…s-to-mode Add access to `--git-verify-signatures-mode` from Helm
Signed-off-by: Kingdon Barrett <[email protected]>
Signed-off-by: Kingdon Barrett <[email protected]>
Chart bump to 1.25.1
This was disabled by default at openssh 8.8 but is still used by some git implementations eg Azure DevOps Signed-off-by: David Hotham <[email protected]>
Allow RSA signatures using SHA-1 hash algorithm
Signed-off-by: Kingdon Barrett <[email protected]>
Signed-off-by: Kingdon Barrett <[email protected]>
When reviewing, changes before 9615263 can be disregarded as they have already been reviewed in (The only commit with relevant changes to review is here: 5b93d3c)
I'm intending on fast-tracking a release for this to avoid inconveniencing anyone else who has upgraded, as soon as I get a confirmation in #3611 that it solves the issue from the prerelease build, or as soon as CI passes. (1.25.2 should likely be out today.) |
will there be a 1.13.1 chart too? Not a big deal either way for me, just asking! |
@dimbleby You betcha: see #3616 I will need a couple of sign-offs from at least one other maintainer to publish the full release including a chart, that is the major release bottleneck for Flux v1 besides actually composing these PRs. It has been a big relief to have helpful outside contributors who can report and confirm such issues that may be from weird external dependencies and send a PR to get it fixed. Thanks very much for your contribution here. I have internalized the release process pretty well now to the point that it takes less than 2 hours from end to end for me to put out a release 👍 the hard part is setting up the repro environment and isolating the actual fix. |
Super - and thank you so much for jumping on this so quickly |
Since this fix came from an external contributor, according to the policies for this repo I am able to approve and merge the PR for prerelease and again for release without any secondary approvals. I cannot publish the chart before I get those approvals though. If this is a high priority for you and you need the chart, please let me know and I will follow up then. It should all be ready early next week anyway, if that's soon enough 👍 |
for fluxcd/flux#3616, fluxcd/flux#3615 Signed-off-by: Kingdon Barrett <[email protected]>
for fluxcd/flux#3616, fluxcd/flux#3615 * add a bunch of excludes to helmrelease for flux v1 * kustomize resource is not relevant for flux v1 The old kustomize should not be used as it is unsafe * flux should not scan for kindest images either * fixup index.docker.io Signed-off-by: Kingdon Barrett <[email protected]>
Details in the CHANGELOG:
https://github.com/fluxcd/flux/blob/361bc170a813c234596c306f8363de39b6683707/CHANGELOG.md#1252-2022-05-26