This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Update kubernetes go client (@ 0.21.3), other go mods #3538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update github.com/shurcooL/vfsgen commit hash to 0d455de * Update golang.org/x/oauth2 commit hash to a41e5a7 * Update golang.org/x/sys commit hash to 0f9fa26 * Update golang.org/x/time commit hash to 1f47c86 * Update module github.com/Masterminds/semver/v3 to v3.1.1 * Update module github.com/gorilla/mux to v1.8.0 * Update module github.com/instrumenta/kubeval to v0.16.1 * Update module github.com/aws/aws-sdk-go to v1.40.7 * Update module github.com/pkg/term to v1 * Update module github.com/prometheus/client_golang to v1.11.0 * Update module k8s.io/apiextensions-apiserver to v0.21.3 * Update module github.com/google/go-github/v28 to v37 * Update module github.com/whilp/git-urls to v1 * Update module k8s.io/klog to v2 * Update module github.com/cheggaaa/pb/v3 to v3.0.8 * Update module github.com/evanphx/json-patch to v4.11.0 * Update module github.com/go-kit/kit to v0.11.0 * Update module github.com/spf13/cobra to v1.2.1 * Update module github.com/fluxcd/helm-operator to v1.4.0 * Update module github.com/imdario/mergo to v0.3.12 * Update module github.com/google/go-containerregistry to v0.5.1 Signed-off-by: Kingdon Barrett <[email protected]> Signed-off-by: Kingdon Barrett <[email protected]>
Signed-off-by: Kingdon Barrett <[email protected]>
* go mod download (go.sum) * go mod updates for helm-operator package * go mod download (helm-operator) * remove github.com/Azure/go-autorest pin (it was failing go mod tidy) Signed-off-by: Kingdon Barrett <[email protected]>
* remove "replace" statement for go-autorest With SOPS upgraded, "go mod tidy" now fails until this is removed. * Resolve client-go issue from upgrade to 1.20 kubernetes/client-go#914 (comment) * register deployments type Signed-off-by: Kingdon Barrett <[email protected]>
Tests failed because: Error: ../../../go/pkg/mod/k8s.io/[email protected]/plugin/pkg/client/auth/exec/metrics.go:21:2: package io/fs is not in GOROOT (/opt/hostedtoolcache/go/1.15.15/x64/src/io/fs) This PR updated the toolchain to Go 1.16.x but CI was not yet upgraded. Adding a commit for that, CI should pass after. Signed-off-by: Kingdon Barrett <[email protected]>
Signed-off-by: Kingdon Barrett <[email protected]>
In context where ctx context is already available, use it Co-authored-by: Hidde Beydals <[email protected]> Signed-off-by: Kingdon Barrett <[email protected]>
This is required in order to maintain compatibility guarantees, since there are breaking changes in 1.22.0 and we support K8s at two versions back prior to the latest version. (We should not be on a latest version until those breaking changes are at least two minor versions ago.) Signed-off-by: Kingdon Barrett <[email protected]>
kingdonb
force-pushed
the
k8s-go-client-1-21
branch
from
3f485a7
to
d10cdbd
Compare
|
The notes in this comment are still the most relevant starting point for deciding what PRs to merge for this release: |
|
In go.mod the version is set to |
Signed-off-by: Kingdon Barrett <[email protected]>
|
Thanks @stefanprodan |
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After today's dev meeting, I understand better what impact there could be for users from #3537 and why we cannot upgrade Flux's kubernetes go client quite that far.
It makes sense to me that we should upgrade to the last release before the breaking change, since it will still be compatible with two versions forward and two versions backwards. I think is the change we should merge instead of #3537.