-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Conversation
5f96e95
to
e4be47b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The preview displays a possible error for me that I think needs to be sorted
There is a problem with this template
YAML error: (): found character that cannot start any token while scanning for the next token at line 50 column 18.
Thank you, I composed this by hand because I couldn't figure out the UI.
This line needed to be quoted, it makes sense that the backtick is not a valid start character for YAML string. I have fixed it and forced pushed over. |
e4be47b
to
2eccae5
Compare
The CI failure was from downloading Helm CLI, which Helm apparently just shut down their Google Storage buckets within the past 48 hours. I cherry-picked a commit from #3530 to resolve it here. |
I think the preview page has become more intelligent, as from what I recall, I used an empty string for the |
Signed-off-by: Kingdon Barrett <[email protected]> Co-authored-by: Hidde Beydals <[email protected]>
Signed-off-by: Kingdon Barrett <[email protected]>
276cd5b
to
2d71706
Compare
How are you validating/previewing? I think there must be some admin controls on the repo that I don't have. On the Settings page, my options are very limited. (That's fine though, thanks for your help!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Template looks good to me, thanks @kingdonb. 💯
@kingdonb by viewing the file in rendered mode, e.g. https://github.com/fluxcd/flux/blob/flux-v1-issue-template/.github/ISSUE_TEMPLATE/bug_report.yaml. All issues are resolved now however, and nothing shows anymore. |
Thanks! |
Based on the issue template from the Flux v2
@hiddeco suggested I make this improvement to reduce the number of questions I need to ask when an issue report is opened, and to stem the tide of folks who might be in the wrong place (meant to report an issue about Flux v2) / still reporting issues about Flux v1 but who are unaware of the maintenance mode status and implications of that with respect to breaking changes or new feature requests and how they can be handled.