Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Specifying automated containers in a HelmRelease #3143

Closed
austinbv opened this issue Jun 17, 2020 · 1 comment · Fixed by #3144
Closed

Specifying automated containers in a HelmRelease #3143

austinbv opened this issue Jun 17, 2020 · 1 comment · Fixed by #3144
Labels
blocked-needs-validation Issue is waiting to be validated before we can proceed bug

Comments

@austinbv
Copy link
Contributor

Describe the bug

We are running into a weird issue with the HelmOperator - We are trying to configure the automated deployments of custom images in the Airflow Helm Chart in the gitsync containers and initContainers. We have added annotations to our helm release and it looks like the below. We are not seeing any logs about the initContainer or gitSync and new images are not detected.

kind: HelmRelease
metadata:
  name: airflow
  namespace: airflow
  annotations:
    fluxcd.io/automated: true

    filter.fluxcd.io/airflow: glob:airflow-dev-*

    filter.fluxcd.io/initContainer: glob:git-*
    repository.fluxcd.io/initContainer: dags.initContainer.image.repository
    tag.fluxcd.io/initContainer: dags.initContainer.image.tag

    filter.fluxcd.io/gitSync: glob:git-*
    repository.fluxcd.io/gitSync: dags.git.gitSync.image.repository
    tag.fluxcd.io/gitSync: dags.git.gitSync.image.tag
spec:
  releaseName: airflow
  chart:
    repository: https://kubernetes-charts.storage.googleapis.com
    version: 7.1.x
    name: airflow
  values:
    airflow:
      image:
        repository: ****.dkr.ecr.****.amazonaws.com/****
        tag: airflow-dev-63b3d5ed649cb3e41611c8fc5eb8dfc583433604
    dags:
      initContainer:
        enabled: true
        image:
          repository: ****.dkr.ecr.****.amazonaws.com/****
          tag: git-41d01deba5c2a08edd5e006fddd8fe8497539a73
      git:
        gitSync:
          enabled: true
          image:
            repository: ****.dkr.ecr.****.amazonaws.com/****
            tag: git-41d01deba5c2a08edd5e006fddd8fe8497539a73

Additional context

  • Helm Operator version: 1.1.0
  • Kubernetes version: v1.16.8-eks-e16311
  • Git provider: github
  • Helm repository provider: stable/airflow

⚠️ ⚠️ ⚠️ ⚠️

Note, this is a direct copy of fluxcd/helm-operator#464 (comment) I was not sure which repo was correct as it's a feature of the helm operator but documentation for this feature is in this repo, and the code is in this repo https://github.com/fluxcd/flux/blob/master/pkg/cluster/kubernetes/resource/helmrelease.go. If I did anything wrong feel free to close the issue!

⚠️ ⚠️ ⚠️ ⚠️
@austinbv austinbv added blocked-needs-validation Issue is waiting to be validated before we can proceed bug labels Jun 17, 2020
@austinbv austinbv mentioned this issue Jun 17, 2020
Closed
@austinbv
Copy link
Contributor Author

Running fluxctl list-images shows clear output that flux is aware the image has been deployed


airflow:statefulset/airflow-worker        git-sync           *****.dkr.ecr.****.amazonaws.com/*****
                                                             |   git-1cd41db74183568c674ea1b84a2db2d43043b27e                   17 Jun 20 17:51 UTC
                                                             '-> git-41d01deba5c2a08edd5e006fddd8fe8497539a73                   17 Jun 20 16:51 UTC
                                                                 airflow-dev-63b3d5ed649cb3e41611c8fc5eb8dfc583433604           17 Jun 20 16:32 UTC
                                                                 git-63b3d5ed649cb3e41611c8fc5eb8dfc583433604                   17 Jun 20 16:30 UTC
                                                                 dev-4a48bcbdf3687f365f2fb0dc5433f38e203021b3                   17 Jun 20 15:03 UTC
                                                                 dev-3e7414cf7bc5080546e8883826d4c9a38d890ce5                   16 Jun 20 16:50 UTC
                                                                 dev-08fa3d8b68641f941fc7925d3c194e047c8c1bb9                   16 Jun 20 16:36 UTC
                                                                 dev-9a5a828665509d0b14e39629a8ff173b1bdf7470                   02 Jun 20 17:55 UTC
                                                                 prod-efb1dc35d18131d35415d4d884fed7da18d9f569                  02 Jun 20 17:55 UTC
                                          airflow-worker     *****.dkr.ecr.****.amazonaws.com/*****
                                                             |   git-1cd41db74183568c674ea1b84a2db2d43043b27e                   17 Jun 20 17:51 UTC
                                                             |   git-41d01deba5c2a08edd5e006fddd8fe8497539a73                   17 Jun 20 16:51 UTC
                                                             '-> airflow-dev-63b3d5ed649cb3e41611c8fc5eb8dfc583433604           17 Jun 20 16:32 UTC
                                                                 git-63b3d5ed649cb3e41611c8fc5eb8dfc583433604                   17 Jun 20 16:30 UTC
                                                                 dev-4a48bcbdf3687f365f2fb0dc5433f38e203021b3                   17 Jun 20 15:03 UTC
                                                                 dev-3e7414cf7bc5080546e8883826d4c9a38d890ce5                   16 Jun 20 16:50 UTC
                                                                 dev-08fa3d8b68641f941fc7925d3c194e047c8c1bb9                   16 Jun 20 16:36 UTC
                                                                 dev-9a5a828665509d0b14e39629a8ff173b1bdf7470                   02 Jun 20 17:55 UTC
                                                                 prod-efb1dc35d18131d35415d4d884fed7da18d9f569                  02 Jun 20 17:55 UTC
                                          git-clone          *****.dkr.ecr.****.amazonaws.com/*****
                                                             |   git-1cd41db74183568c674ea1b84a2db2d43043b27e                   17 Jun 20 17:51 UTC
                                                             '-> git-41d01deba5c2a08edd5e006fddd8fe8497539a73                   17 Jun 20 16:51 UTC
                                                                 airflow-dev-63b3d5ed649cb3e41611c8fc5eb8dfc583433604           17 Jun 20 16:32 UTC
                                                                 git-63b3d5ed649cb3e41611c8fc5eb8dfc583433604                   17 Jun 20 16:30 UTC
                                                                 dev-4a48bcbdf3687f365f2fb0dc5433f38e203021b3                   17 Jun 20 15:03 UTC
                                                                 dev-3e7414cf7bc5080546e8883826d4c9a38d890ce5                   16 Jun 20 16:50 UTC
                                                                 dev-08fa3d8b68641f941fc7925d3c194e047c8c1bb9                   16 Jun 20 16:36 UTC
                                                                 dev-9a5a828665509d0b14e39629a8ff173b1bdf7470                   02 Jun 20 17:55 UTC
                                                                 prod-efb1dc35d18131d35415d4d884fed7da18d9f569                  02 Jun 20 17:55 UTC

@austinbv austinbv changed the title Specifying automated containers for airflow helm Specifying automated containers in a helm release Jun 17, 2020
@austinbv austinbv changed the title Specifying automated containers in a helm release Specifying automated containers in a HelmRelease Jun 17, 2020
@austinbv austinbv mentioned this issue Jun 18, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
blocked-needs-validation Issue is waiting to be validated before we can proceed bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Specific documentation for HelmRelease Automation
1 participant
@austinbv