Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for headless service #1679

Open
andrew-demb opened this issue Jul 11, 2024 · 0 comments
Open

Support for headless service #1679

andrew-demb opened this issue Jul 11, 2024 · 0 comments

Comments

@andrew-demb
Copy link
Contributor

Describe the feature

We created a headless service for our application and created a Canary resource to enable Flagger.

However, after creating Canary resources we found, that service resources created by Flagger are not headless services.

After a short investigation, we found this code:

// Reset and let K8s assign the IP. Otherwise we get an error due to the IP is already assigned

Which looks like a reset field to avoid errors on resource creation, but not for forbidding using headless services.

So the question is: is it intended not to preserve the headless service type?

Proposed solution

Check for the ClusterIP: None value to decide on the reset field ClusterIP value.

Any alternatives you've considered?

N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant