You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This automatically creates a new HPA object app-primary which manages the primary deployment. However, due to not being able to set annotations on the app-primary HPA and actually not using the HPA at all (min = max) we decided to remove the HPA (app) and the autoscalerRef.
In general this works fine, however we noticed that the HPA that was automatically created by flagger (app-primary) does not get deleted automatically.
Is this intended or a bug? In case it is intended, would you think it is significant enough to mention the cleanup process in the docs (delete all remaining .+-primary HPAs that do no longer have a corresponding canary HPA)?
To Reproduce
create a Canary with autoscalerRef enabled. This will create a .+-primary HPA object
remove the Canary HPA and the reference from the kind: Canary object
The .+-primary will still be present and manage the .+-primary deployment, even though your intention is now to manage the replicas of your deployment directly
Expected behavior
Resources that get created automatically when enabling a flag (autoscalerRef) also get deleted when the flag is removed. Otherwise the HPA created by flagger will still manage the amount of replicas for the primary deployment and the user does not have a way to update the amount of replicas without deleting the objects manually.
Describe the bug
We are currently using
canaries
withautoscalerRef
and HPA enabled as described in the docs.This automatically creates a new HPA object
app-primary
which manages the primary deployment. However, due to not being able to set annotations on theapp-primary
HPA and actually not using the HPA at all (min = max) we decided to remove the HPA (app
) and theautoscalerRef
.In general this works fine, however we noticed that the HPA that was automatically created by flagger (
app-primary
) does not get deleted automatically.Is this intended or a bug? In case it is intended, would you think it is significant enough to mention the cleanup process in the docs (delete all remaining
.+-primary
HPAs that do no longer have a corresponding canary HPA)?To Reproduce
autoscalerRef
enabled. This will create a.+-primary
HPA objectkind: Canary
object.+-primary
will still be present and manage the.+-primary
deployment, even though your intention is now to manage thereplicas
of your deployment directlyExpected behavior
Resources that get created automatically when enabling a flag (
autoscalerRef
) also get deleted when the flag is removed. Otherwise the HPA created by flagger will still manage the amount of replicas for the primary deployment and the user does not have a way to update the amount of replicas without deleting the objects manually.Additional context
The text was updated successfully, but these errors were encountered: