Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Rollout hook "failure counter" #1501

Open
wispum opened this issue Aug 31, 2023 · 0 comments
Open

New Rollout hook "failure counter" #1501

wispum opened this issue Aug 31, 2023 · 0 comments

Comments

@wispum
Copy link

wispum commented Aug 31, 2023

Describe the feature

Most of our services have no steady incoming traffic flow, but more of an eventual traffic spikes, so we want to pause canary for "canary step interval" and retry again metrics checking.
We know that flagger has ability to do it by "rollout hook" but there is no ability to skip increasing failure counter.

Proposed solution

For such purpose we want to add parameter into webhook (only for "rollout hook" if it's possible) - failureCounter. If this parameter is defined we skip increasing "total canary failure counter" (treshold) and increase only new one. If this failureCounter will be reached then whole canary will be stopped (or another phase, it can be discussed too). This failure counter will be optional and won't impact on default behaviour.
We want to develop this feature by ourselves and contribute to your project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant