Make cluster role name configurable #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrepopescu21
changed the title
|
@stefanprodan I see you're active around here, PTAL 🫶🏻 |
Signed-off-by: Petre <[email protected]>
petrepopescu21
force-pushed
the
feature/rbac-role-in-values
branch
from
9e4e8fc to
815c553
Compare
haarchri
approved these changes
Mar 3, 2024
|
@haarchri wasn't this covered in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Users should be able to assign a lower-scope ClusterRole to the reconciler which does not have full cluster admin privileges. This PR replaces the hardcoded name with a value
Special notes for your reviewer:
Checklist
make reviewable