-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rfc7: add item about inclusive language #256
Comments
Good idea.
"worker" would be another replacement which I hear often one of these days. Do you want to also add terms like "master" and "whitelist" as well? I plan to replace "whitelist" too allowlist in Fluxion. I don't know what to do w/ master though when the main trunk is called "master." |
Seems like a good idea. Perhaps we should pick a convention that we prefer? i.e. leader/follower, blocklist/allowlist, or what not? (I think leader/follower is what I've done in my few PRs).
Github is apparently going to be changing the default. I'd suggest we wait to see what default they choose, then we can manually adjust our repos to that. |
Doh! I had missed that while trying to update all the flux projects (I think I only grepped "master", "slave", and "blacklist"). I can fix that up quick. |
Sorry I didn't let you know earlier. |
I think it might depend on context. We don't want to as restrictive as, say, pylint in our naming conventions. I like the list of suggestions from the doc @garlick referenced. For allowlist I also see that Travis-CI uses Another idea, we could enhance |
Agreed there is context and we wouldn't always want to restrict to certain ones. Just don't want people to start calling some code "coordinator-worker" when we use "leader-follower" in other places. But I guess code-reviews will be good enough to catch those cases. |
Good point! |
Shall we add a statement about inclusive language to our style guide?
As an example the following patch was proposed on LMKL:
https://lkml.org/lkml/2020/7/4/229
Their coding-style.rst change is:
Plus there's a new inclusive-terminology.rst document that we could perhaps cite if we want.
The text was updated successfully, but these errors were encountered: