Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The version attribute is missing from the R #480

Closed
dongahn opened this issue Jun 28, 2019 · 3 comments
Closed

The version attribute is missing from the R #480

dongahn opened this issue Jun 28, 2019 · 3 comments

Comments

@dongahn
Copy link
Member

dongahn commented Jun 28, 2019

What's emitted

2019-06-28T17:57:30.207491Z qmanager.info[0]: jobid (576431587328): {"execution":{"R_lite":[{"rank":0,"node":"59fa0c6cd2b8","children":{"core":"3"}}]}}

This led to the new execution system's reader error.

{"timestamp":1561744650.2166536,"name":"exception","context":{"note":"reading R: Object item not found: version"}}
@dongahn
Copy link
Member Author

dongahn commented Jun 28, 2019

It was easy to fix. But then, I get

{"timestamp":1561745825.5159779,"name":"exception","context":{"note":"reading R: R_lite: failed to read target rank list"}}
{"version": 1,"execution":{"R_lite":[{"rank":-1,"node":"node0","children":{"core":"35"}}]}}

Change the issue title to capture all of these RV1 compat issues.

@dongahn
Copy link
Member Author

dongahn commented Jun 28, 2019

Wrong log:

> {"version": 1,"execution":{"R_lite":[{"rank":-1,"node":"node0","children":{"core":"35"}}]}}
< {"version": 1,"execution":{"R_lite":[{"rank":0,"node":"59fa0c6cd2b8","children":{"core":"3"}}]}}

So it turned out, rank info was correctly there with hwloc reader. But the rv1 writer emits the rank as an integer not as a string. After this schema fix:

2019-06-28T19:01:35.899599Z qmanager.info[0]: jobid (212114341888): {"version":1,"execution":{"R_lite":[{"rank":"0","node":"59fa0c6cd2b8","children":{"core":"3"}}]}}

ahn1@59fa0c6cd2b8:/usr/src/scratch$ flux job id --to=kvs 212114341888
job.0000.0031.6300.0000
ahn1@59fa0c6cd2b8:/usr/src/scratch$ flux kvs get -r job.0000.0031.6300.0000.guest.exec.eventlog
{"timestamp":1561748495.907171,"name":"init"}
{"timestamp":1561748495.9112291,"name":"starting"}
{"timestamp":1561748495.9112711,"name":"running","context":{"timer":"3600.000000s"}}
ahn1@59fa0c6cd2b8:/usr/src/scratch$

This was the first working end-to-end run!

@dongahn
Copy link
Member Author

dongahn commented Jul 11, 2019

PR #481 resolved this.

@dongahn dongahn closed this as completed Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant