Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluxion Valgrind tests aren't run #1136

Closed
milroy opened this issue Jan 31, 2024 · 0 comments · Fixed by #1061
Closed

Fluxion Valgrind tests aren't run #1136

milroy opened this issue Jan 31, 2024 · 0 comments · Fixed by #1061

Comments

@milroy
Copy link
Member

milroy commented Jan 31, 2024

The migration from autotools to cmake has resulted in Valgrind tests not being run. I discovered this while working on PR #1061. I realized that a few changes to planner introduced memory leaks that weren't caught by t5000-valgrind.t. Upon examination, have_valgrind_h is false

if ! have_valgrind_h && test "$debug" = ""; then

and the test is skipped. We need to add a FindValgrind.cmake to detect the valgrind location and set HAVE_VALGRIND, updating t5000-valgrind.t appropriately.

@milroy milroy linked a pull request Jan 31, 2024 that will close this issue
@mergify mergify bot closed this as completed in #1061 Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant