You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The migration from autotools to cmake has resulted in Valgrind tests not being run. I discovered this while working on PR #1061. I realized that a few changes to planner introduced memory leaks that weren't caught by t5000-valgrind.t. Upon examination, have_valgrind_h is false
and the test is skipped. We need to add a FindValgrind.cmake to detect the valgrind location and set HAVE_VALGRIND, updating t5000-valgrind.t appropriately.
The text was updated successfully, but these errors were encountered:
The migration from autotools to cmake has resulted in Valgrind tests not being run. I discovered this while working on PR #1061. I realized that a few changes to planner introduced memory leaks that weren't caught by
t5000-valgrind.t
. Upon examination,have_valgrind_h
is falseflux-sched/t/t5000-valgrind.t
Line 33 in 7b1a79f
and the test is skipped. We need to add a
FindValgrind.cmake
to detect thevalgrind
location and setHAVE_VALGRIND
, updatingt5000-valgrind.t
appropriately.The text was updated successfully, but these errors were encountered: