Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource graph reinitialization with existing jobs leaves idata inconsistent #1075

Closed
milroy opened this issue Sep 15, 2023 · 1 comment
Closed

Comments

@milroy
Copy link
Member

milroy commented Sep 15, 2023

As @zekemorton discovered during test case development of PR #1053, reinitialization of the resource graph (i.e. here) leaves the resource graph idata in an inconsistent state. As an example:

$ ./resource-query -L ../../t/data/resource/jgfs/elastic/node-test.json -f jgf -S CA -P low
INFO: Loading a matcher: CA
resource-query> m allocate ../../t/data/resource/jobspecs/elastic/test-ma-node.yaml
[snip]
      ---------------core34[1:x]
      ---------------core35[1:x]
      ------------socket1[1:x]
      ---------node0[1:x]
      ------rack0[1:s]
      ---medium0[1:s]
INFO: =============================
INFO: JOBID=1
INFO: RESOURCES=ALLOCATED
INFO: SCHEDULED AT=Now
INFO: =============================
resource-query> attach ../../t/data/resource/jgfs/elastic/node-add-test.json
resource-query> cancel 1
rem_agfilter: planner_multi_rem_span returned -1.
medium0.
No such file or directory
ERROR: error encountered while removing job 1
resource-query> 

The error is caused by replacing a populated planner_multi_t with an empty one here:

(*m_graph)[u].idata.subplans[s] = p;

To solve this, we will likely need a way to partially remove a span from planner and planner_multi and update their resource counts.

@milroy
Copy link
Member Author

milroy commented Mar 26, 2024

Closing since this was resolved in PR #1061.

@milroy milroy closed this as completed Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant