From 0ea1aae23203df7bd55764fe9f4bddb746aa1061 Mon Sep 17 00:00:00 2001 From: "Mark A. Grondona" Date: Mon, 2 Oct 2023 06:59:01 -0700 Subject: [PATCH] build: do not install libresource.so Problem: libresource.so was previously a convenience library, but is now installed by default. However, it has a generic name that could easily become confusing, and is named simply `libresource.so`, which doesn't follow standard shared library naming conventions. Make libresource a static convenience library instead and do not install it. The library should be renamed something like `libfluxion-resoruce.so` and possibly be versioned with an soname if installed in the future. Fixes #1093 --- resource/CMakeLists.txt | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/resource/CMakeLists.txt b/resource/CMakeLists.txt index 64a7dd408..4c1cfc974 100644 --- a/resource/CMakeLists.txt +++ b/resource/CMakeLists.txt @@ -40,7 +40,7 @@ set(RESOURCE_HEADERS store/resource_graph_store.hpp ) -add_library(resource SHARED +add_library(resource STATIC policies/dfu_match_locality.cpp policies/dfu_match_var_aware.cpp policies/dfu_match_policy_factory.cpp @@ -87,8 +87,6 @@ target_link_libraries(resource PUBLIC jobspec_conv Boost::filesystem ) -install(TARGETS resource - LIBRARY) add_subdirectory(modules) add_subdirectory(reapi)