Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content: support RFC10 defined blob size limit #6457

Open
chu11 opened this issue Nov 21, 2024 · 0 comments
Open

content: support RFC10 defined blob size limit #6457

chu11 opened this issue Nov 21, 2024 · 0 comments

Comments

@chu11
Copy link
Member

chu11 commented Nov 21, 2024

in content/cache.c

/* Raise the max blob size value to 1GB so that large KVS values
 * (including KVS directories) can be supported while the KVS transitions
 * to the RFC 11 treeobj data representation.
 */
//static const uint32_t default_blob_size_limit = 1048576; /* RFC 10 */
static const uint32_t default_blob_size_limit = 1048576*1024;

this is mostly a reminder that we need to re-look at what would be necessary to make this work or if RFC10 should be updated with a larger limit. #1202 & #1206 are probably involved in the requirement to make it work.

as a side note, if the average sha has is 46 bytes in size, counting the quotes around it and the comma separating each one in a valref array, that's about a max of 21K blobref's in a valref array. We definitely got eventlogs with more than that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant