Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test failure: t2801-top-cmd.t 16 - flux-top can call itself recursively #4169

Closed
chu11 opened this issue Feb 28, 2022 · 1 comment
Closed
Assignees

Comments

@chu11
Copy link
Member

chu11 commented Feb 28, 2022

everyonce in awhile when i run make -j16 check this test fails. I assume something racy, but the cause escapes me.

test_expect_success NO_CHAIN_LINT 'flux-top can call itself recursively' '
	SHELL=/bin/sh &&
	flux jobs &&
	flux proxy $(cat jobid2) flux jobs -c1 -no {id} >expected.id &&
	cat <<-EOF >recurse.in &&
	{ "version": 2 }
	[0.5, "i", "j"]
	[0.55, "i", "j"]
	[0.60, "i", "j"]
	[0.65, "i", "k"]
	[0.70, "i", "\n"]
	[1.00, "i", "q"]
	[1.10, "i", "q"]
	EOF
	$runpty -o recurse.log --input=recurse.in flux top &&
	grep -q $(echo $(cat expected.id) | sed "s/ƒ//") recurse.log
'

Edit: side note, tests that occasionally fail but have a -t 30 or some similar timeout, its easy to just accept the failure. But in this test I can't tell if a timeout would be reasonable.

@chu11
Copy link
Member Author

chu11 commented Mar 9, 2022

taking a little time to learn about this test, I'm guessing the race / error is the timestamps in the first field of the inputs above. The 1/10th or 1/20th of a second between inputs might not be a large enough time if the rpcs flux top is performing internally are too slow. We don't see this much, but if we begin to see it more, increasing those timestamps might be worthwhile, like perhaps .25 seconds between inputs.

Edit: I guess its also possible the very first command done at 0.5 seconds in could be too early?

@chu11 chu11 changed the title test fiailure: t2801-top-cmd.t 16 - flux-top can call itself recursively test failure: t2801-top-cmd.t 16 - flux-top can call itself recursively Mar 10, 2022
@chu11 chu11 self-assigned this Apr 7, 2022
@mergify mergify bot closed this as completed in 2de6b30 Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant