Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flux API: replace json_object with string #169

Closed
garlick opened this issue Apr 24, 2015 · 6 comments
Closed

Flux API: replace json_object with string #169

garlick opened this issue Apr 24, 2015 · 6 comments

Comments

@garlick
Copy link
Member

garlick commented Apr 24, 2015

json_object appears in the Flux API, which creates a dependency on json-c for users.

Consider revising the API so that strings are passed instead of json_object. This may include revising RFC 3 so that FLUX_MSGFLAG_JSON is replaced with FLUX_MSGFLAG_STRING.

@garlick
Copy link
Member Author

garlick commented Apr 24, 2015

Issue #76 proposes replacing JSON with opaque data in the KVS.

@grondo
Copy link
Contributor

grondo commented Apr 24, 2015

To clarify (sorry if this is obvious) but you'd be replacing json_object with a valid JSON string (In which case FLUX_MSGFLAG_JSON actually still applies), or is the proposal to replace json_object with arbitrary, unformatted string?

@grondo
Copy link
Contributor

grondo commented Apr 24, 2015

Just throwing another idea out there, maybe this is what you had in mind anyway, but if there is already generic get/set_payload message methods, can we just drop the json specific calls from the public APIs (keeping them perhaps as internal convenience functions) and note the payload format in msgflags?

This may be a gross oversimplification of the problem because I haven't traversed the entire API in awhile...

@garlick
Copy link
Member Author

garlick commented Apr 24, 2015

@grondo: you're probably right on both counts.

@garlick
Copy link
Member Author

garlick commented May 13, 2015

I kept the get/set_payload message methods in in PR #189 as it seemed like it was appropriate to have the validation that payload has terminating NULL, etc., testing message flags, etc., down there in the low level code.

@garlick
Copy link
Member Author

garlick commented Jun 6, 2015

PR #215 gets rid of json_object from libflux-core.so.

Since #76 is tracking the removal of json_object from the KVS interface, and libkvs.so is a separate library from the core, I think we can close this one.

@garlick garlick closed this as completed Jun 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants