-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flux_event_[un]subscribe should return a future #1557
Comments
Because zeromq SUB sockets have a non-blocking subscribe/unsubscribe operation, struct flux_handle_ops {
...
int (*event_subscribe)(void *impl, const char *topic);
int (*event_unsubscribe)(void *impl, const char *topic);
} Yet the These operations will need to be dropped and the API functions implemented directly in terms of the RPCs formerly hidden within the operations. |
As a round 1 refactoring/implementation, discussed having this function return a fulfilled future. |
This issue has been automatically marked as stale because it has not had activity for 365 days. It will be closed if no further activity occurs within 14 days. Thank you for your contributions. |
We have these now so closing. flux_future_t *flux_event_subscribe_ex (flux_t *h,
const char *topic,
int flags);
flux_future_t *flux_event_unsubscribe_ex (flux_t *h,
const char *topic,
int flags); |
flux_event_subscribe()
andflux_event_unsubscribe()
hide synchronous RPCs in some cases, therefore it should be changed to return a future so that it can be used in reactive programs without blocking the reactor loop.The text was updated successfully, but these errors were encountered: