You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I expect that the chain should abort at any phase where there is an error. Unfortunately, our autogen.sh always returns success, even when libtoolize or autoreconf fail. That is easy enough to fix, but I have a couple of other questions before I submit a pull request:
Why are we deleting the autom4te.cache? Will there be any objection if I take that out?
The "-I config" on the autoreconf line appears to be redundant (because we configured that in configure.ac) and results in it running commands like "aclocal -I config -I config". Any reason not to remove that?
The text was updated successfully, but these errors were encountered:
Looking back it appears I'm responsible for the autom4te.cache removal. I don't remember why.
Sounds like the extra -I config accomplishes nothing. I'd say go ahead on all counts.
I frequently do something like:
I expect that the chain should abort at any phase where there is an error. Unfortunately, our autogen.sh always returns success, even when libtoolize or autoreconf fail. That is easy enough to fix, but I have a couple of other questions before I submit a pull request:
Why are we deleting the autom4te.cache? Will there be any objection if I take that out?
The "-I config" on the autoreconf line appears to be redundant (because we configured that in configure.ac) and results in it running commands like "aclocal -I config -I config". Any reason not to remove that?
The text was updated successfully, but these errors were encountered: