Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autogen.sh issues #1162

Closed
morrone opened this issue Aug 24, 2017 · 1 comment
Closed

autogen.sh issues #1162

morrone opened this issue Aug 24, 2017 · 1 comment
Assignees

Comments

@morrone
Copy link
Contributor

morrone commented Aug 24, 2017

I frequently do something like:

sh autogen.sh && ./configure && make -j8

I expect that the chain should abort at any phase where there is an error. Unfortunately, our autogen.sh always returns success, even when libtoolize or autoreconf fail. That is easy enough to fix, but I have a couple of other questions before I submit a pull request:

Why are we deleting the autom4te.cache? Will there be any objection if I take that out?

The "-I config" on the autoreconf line appears to be redundant (because we configured that in configure.ac) and results in it running commands like "aclocal -I config -I config". Any reason not to remove that?

@garlick
Copy link
Member

garlick commented Aug 24, 2017

Looking back it appears I'm responsible for the autom4te.cache removal. I don't remember why.
Sounds like the extra -I config accomplishes nothing. I'd say go ahead on all counts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants