You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It looks like src/common/libflux/dispatch.h should be renamed to msg_handler.h, since the header is almost entirely about flux_msg_handler_* function prototypes and data types.
The only appearance of the word "dispatch" in that header is in flux_dispatch_requeue(). That function only operates on a flux_t , and has no operation on flux_msg_ types to it looks like it is probably in the wrong header to begin with.
I'm guessing there are historical reasons for this since "dispatch" occurs often in dispatch.c. dispatch.c could either be renamed to msg_handler.c, or perhaps the msg_handler_* functions could be broken out into a separate msg_handler.c and leave dispatch.c in place...
The text was updated successfully, but these errors were encountered:
dispatch.c contains both internal message dispatch code and external flux_msg_handler functions. The header is named dispatch.h to match where it's implementation is. The header is generally included indirectly through flux/core.h by users so I'm not sure the name matters that much. That said, if you think it's a good idea, I would not be opposed to renaming either or both to flux_msg_handler.[ch].
It looks like src/common/libflux/dispatch.h should be renamed to msg_handler.h, since the header is almost entirely about flux_msg_handler_* function prototypes and data types.
The only appearance of the word "dispatch" in that header is in flux_dispatch_requeue(). That function only operates on a flux_t , and has no operation on flux_msg_ types to it looks like it is probably in the wrong header to begin with.
I'm guessing there are historical reasons for this since "dispatch" occurs often in dispatch.c. dispatch.c could either be renamed to msg_handler.c, or perhaps the msg_handler_* functions could be broken out into a separate msg_handler.c and leave dispatch.c in place...
The text was updated successfully, but these errors were encountered: