From b27c5ea021aff73776d2b6da8b1037f3ce71d3a6 Mon Sep 17 00:00:00 2001 From: Albert Chu Date: Fri, 26 Aug 2022 14:44:06 -0700 Subject: [PATCH] broker: log content store errors to LOG_CRIT Problem: In the event of content store errors, such as ENOSPC if the disk is full, error messages are logged to LOG_ERR. This does not properly signify the severity of the error, as something like ENOSPC would mean no data is being backed up to disk. Solution: Log to LOG_CRIT, to signify the importance of this issue and the need for it to be resolved. --- src/broker/content-cache.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/broker/content-cache.c b/src/broker/content-cache.c index 2d12fad71ae0..2fd723935c0e 100644 --- a/src/broker/content-cache.c +++ b/src/broker/content-cache.c @@ -505,7 +505,8 @@ static void cache_store_continuation (flux_future_t *f, void *arg) flux_log (cache->h, LOG_DEBUG, "content store: %s", "backing store service unavailable"); else - flux_log_error (cache->h, "content store"); + flux_log (cache->h, LOG_CRIT, "content store: %s", + strerror (errno)); goto error; } if (hash_size != content_hash_size