Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin: enforce preemptible-after limits, set preemptible-after default #555

Open
Tracked by #552
cmoussa1 opened this issue Dec 19, 2024 · 0 comments
Open
Tracked by #552
Assignees
Labels
new feature new feature plugin related to the multi-factor priority plugin

Comments

@cmoussa1
Copy link
Member

The priority plugin will need to do two separate things concerning preemptible-after attributes for a job:

  1. If an association does not set a preemptible-after attribute for their job and they are running under a special bank that has max-preemptible-after configured, the job should be updated to include this attribute. This could probably happen in the callback for job.new, where default bank and default project name jobspec-updates are also currently happening.
  2. If an association does set a preemptible-after attribute for their job, it should be validated to make sure that the value is not greater than the max-preemptible-after value set for the bank. If it is, it should automatically be lowered to whatever the max is. I'm thinking this could probably also happen in the callback for job.new since jobs won't be rejected in case the value is too high, it'll just be updated.
@cmoussa1 cmoussa1 added new feature new feature plugin related to the multi-factor priority plugin labels Dec 19, 2024
@cmoussa1 cmoussa1 self-assigned this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature new feature plugin related to the multi-factor priority plugin
Projects
None yet
Development

No branches or pull requests

1 participant