Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

printVersionNotice sometimes fails #252

Closed
ManuelRauber opened this issue Aug 17, 2023 · 1 comment
Closed

printVersionNotice sometimes fails #252

ManuelRauber opened this issue Aug 17, 2023 · 1 comment

Comments

@ManuelRauber
Copy link

Describe the bug
I noticed that on our CI system the configurator script sometimes fails with this error message:

Downloading https://api.github.com/repos/fluttercommunity/font_awesome_flutter/releases
Unhandled exception:
type '_Map<String, dynamic>' is not a subtype of type 'List<dynamic>'
#0      printVersionNotice (file:///Users/runner/work/1/s/vendor/font_awesome_flutter/font_awesome_flutter/util/lib/main.dart:484:10)
<asynchronous suspension>
#1      main (file:///Users/runner/work/1/s/vendor/font_awesome_flutter/font_awesome_flutter/util/lib/main.dart:96:3)
<asynchronous suspension>

Most of the time, if I re-run everything, it works again. Maybe the GitHub API has an hiccup or something.

But since it's only printing version information, it should not break the build.

Do you think it would be possible to wrap it in a try/catch and simply print something like "Could not determine version information" or something, but not break the build?

@michaelspiss
Copy link
Collaborator

Hey @ManuelRauber, sorry for the long waiting time. printVersionInformation's catch seems to have been too narrow to accommodate for different responses from what was expected. This is fixed with the latest release. Thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants