Move test to github actions. #288
Conversation
We are moving tests to actions to reduce the maintenance effort.
| test_linux: | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| fail-fast: true |
There was a problem hiding this comment.
what's the opposite of "fail-fast"? (and what's the default?)
There was a problem hiding this comment.
The default is True. The opposite is continue_on_error which will continue running all the shards even if one of them fails. https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstrategyfail-fast
There was a problem hiding this comment.
if the default is true, should be omit this line? having a line that sets the value to the default is generally misleading (people will assume it's doing something intentional)
There was a problem hiding this comment.
Sounds good, I'll send a fix!
| shard-index: 0 | ||
| - name: tests-macos-1 | ||
| shards: 2 | ||
| shard-index: 1 |
There was a problem hiding this comment.
i worry that this method of sharding is going to mean we end up missing shards one day and not noticing (like if someone just increases the "shards" number but doesn't add a new "shard-index" line). Is there any way to guarantee that all the shards are present?
There was a problem hiding this comment.
From a quick look to the docs I didn't find anything that could be used to calculate indexes programmatically before actions read the file and triggers the builds.
We are moving tests to actions to reduce the maintenance effort.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.