Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update macos_ui.test #283

Merged
merged 2 commits into from
Aug 1, 2023
Merged

Update macos_ui.test #283

merged 2 commits into from
Aug 1, 2023

Conversation

Piinks
Copy link
Contributor

@Piinks Piinks commented Jul 31, 2023

Updates commit for macosui/macos_ui#467 which unblocks flutter/flutter#131631

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Piinks
Piinks commented Jul 31, 2023
View reviewed changes
registry/macos_ui.test Outdated Show resolved Hide resolved
Piinks
Piinks commented Aug 1, 2023
View reviewed changes
registry/macos_ui.test Outdated Show resolved Hide resolved
pdblasi-google
pdblasi-google approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@pdblasi-google pdblasi-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Piinks Piinks merged commit 56498c0 into main Aug 1, 2023
@Piinks Piinks deleted the Piinks-patch-1 branch August 1, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GroovinChip GroovinChip GroovinChip left review comments

@pdblasi-google pdblasi-google pdblasi-google approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Piinks @GroovinChip @pdblasi-google