Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add devtools tests #258

Closed
wants to merge 2 commits into from
Closed

Add devtools tests #258

wants to merge 2 commits into from

Conversation

Piinks
Copy link
Contributor

@Piinks Piinks commented May 11, 2023

Add the flutter/devtools test suite for checking against changes in flutter/flutter

Fixes flutter/devtools#4433

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks
Copy link
Contributor Author

Piinks commented May 11, 2023

For this, I will need to write a custom script in devtools to run the tests. I will follow up on this tomorrow

@@ -0,0 +1,12 @@
# Tests from https://github.com/flutter/devtools

[email protected]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this typically a single person or a google group? If it does need a primary POC then that is fine to be me but can we add a secondary contact [email protected]?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely, I'll update this.

@Piinks
Copy link
Contributor Author

Piinks commented May 15, 2023

Hmm... Looks like a bunch of tests are timing out. and not all of the expected mocks are created by the generate script.

@Piinks
Copy link
Contributor Author

Piinks commented May 15, 2023

Closing since the devtools tests aren't working in this environment as expected right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add DevTools tests to Flutter Customer Test Registry
2 participants