Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update platform_channels for upcoming release #656

Closed
domesticmouse opened this issue Jan 18, 2021 · 7 comments
Closed

Update platform_channels for upcoming release #656

domesticmouse opened this issue Jan 18, 2021 · 7 comments
Assignees
Labels
enhancement New feature or request p1
Milestone

Comments

@domesticmouse
Copy link
Contributor

From failing CI run:

== Testing 'platform_channels' on Flutter's beta channel ==
~/work/samples/samples/platform_channels ~/work/samples/samples
Running "flutter pub get" in platform_channels...                  888ms
Analyzing platform_channels...                                  

   info • 'showSnackBar' is deprecated and shouldn't be used. Use ScaffoldMessenger.showSnackBar. This feature was deprecated after v1.23.0-14.0.pre. • lib/src/method_channel_demo.dart:87:26 • deprecated_member_use
   info • 'showSnackBar' is deprecated and shouldn't be used. Use ScaffoldMessenger.showSnackBar. This feature was deprecated after v1.23.0-14.0.pre. • lib/src/pet_list_screen.dart:28:34 • deprecated_member_use
   info • 'showSnackBar' is deprecated and shouldn't be used. Use ScaffoldMessenger.showSnackBar. This feature was deprecated after v1.23.0-14.0.pre. • lib/src/pet_list_screen.dart:96:26 • deprecated_member_use
@domesticmouse domesticmouse self-assigned this Jan 18, 2021
@AyushBherwani1998
Copy link
Member

Happy to help and update sample @domesticmouse :)

@domesticmouse
Copy link
Contributor Author

Thank you @AyushBherwani1998, PRs always gratefully accepted =)

@RedBrogdon
Copy link
Contributor

Relevant breaking change doc: https://flutter.dev/docs/release/breaking-changes/scaffold-messenger

Good to see you again, @AyushBherwani1998! I hope you're doing well.

@AyushBherwani1998
Copy link
Member

Hey @RedBrogdon. Thanks, I'm doing good. I hope you are doing well too.

@RedBrogdon RedBrogdon added enhancement New feature or request p1 labels Jan 31, 2021
@RedBrogdon RedBrogdon added this to the Backlog milestone Jan 31, 2021
@RedBrogdon
Copy link
Contributor

I've brought the beta branch up to date so this can be landed there.

@adarsh-technocrat
Copy link
Contributor

Hello @domesticmouse as related PR has been to merge to the beta branch we can close this issue :)

@domesticmouse
Copy link
Contributor Author

Thank you again 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request p1
Projects
None yet
Development

No branches or pull requests

4 participants