Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Many] Update compile sdk and target sdk in packages example apps to 34 or higher. #152929

Open
reidbaker opened this issue Aug 6, 2024 · 0 comments · May be fixed by flutter/packages#7910
Open
Assignees
Labels
fyi-ecosystem For the attention of Ecosystem team P1 High-priority issues at the top of the work list package flutter/packages repository. See also p: labels. platform-android Android applications specifically team-android Owned by Android platform team

Comments

@reidbaker
Copy link
Contributor

For each android package:

  • In android studio import /_android/example/android/build.gradle
  • Open example/android/app/build.gradle
  • Use AGP upgrade assistant to update compileSdk and targetSdk, this may require other changes like marking activities as exported or updating gradle/kotlin etc
  • If an example app cant be updated or the updates require a large reworking of plugin code file an issue linked to this issue documenting which example app, what issues were run into and a suggested course of action.
@reidbaker reidbaker added platform-android Android applications specifically package flutter/packages repository. See also p: labels. P1 High-priority issues at the top of the work list team-android Owned by Android platform team fyi-ecosystem For the attention of Ecosystem team labels Aug 6, 2024
@bartekpacia bartekpacia changed the title [Many] Update compile sdk and target sdk in plackages example apps to 34 or higher. [Many] Update compile sdk and target sdk in packages example apps to 34 or higher. Aug 11, 2024
yaakovschectman added a commit to flutter/packages that referenced this issue Sep 13, 2024
Bump up target SDK for each Android example app, bump version and
changelog, and as necessary export activities and update permissions.

For each package, I ensured the example app ran on an emulator before
and after the upgrade and compared its behavior, as well as running the
integration tests to confirm they pass.

flutter/flutter#152929

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] page, which explains my
responsibilities.
- [x] I read and followed the [relevant style guides] and ran the
auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages
repo does use `dart format`.)
- [ ] I signed the [CLA].
- [x] The title of the PR starts with the name of the package surrounded
by square brackets, e.g. `[shared_preferences]`
- [x] I [linked to at least one issue that this PR fixes] in the
description above.
- [x] I updated `pubspec.yaml` with an appropriate new version according
to the [pub versioning philosophy], or this PR is [exempt from version
changes].
- [x] I updated `CHANGELOG.md` to add a description of the change,
[following repository CHANGELOG style], or this PR is [exempt from
CHANGELOG changes].
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/packages/blob/main/CONTRIBUTING.md
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md
[relevant style guides]:
https://github.com/flutter/packages/blob/main/CONTRIBUTING.md#style
[CLA]: https://cla.developers.google.com/
[Discord]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md
[linked to at least one issue that this PR fixes]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview
[pub versioning philosophy]: https://dart.dev/tools/pub/versioning
[exempt from version changes]:
https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#version
[following repository CHANGELOG style]:
https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog-style
[exempt from CHANGELOG changes]:
https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog
[test-exempt]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fyi-ecosystem For the attention of Ecosystem team P1 High-priority issues at the top of the work list package flutter/packages repository. See also p: labels. platform-android Android applications specifically team-android Owned by Android platform team
Projects
None yet
2 participants