Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

Address l10n errors #893

Closed
guidezpl opened this issue Feb 10, 2023 · 2 comments · Fixed by #900
Closed

Address l10n errors #893

guidezpl opened this issue Feb 10, 2023 · 2 comments · Fixed by #900
Assignees
@thkim1011
Labels
bug Something isn't working P1 Priority 1 - Must have

Comments

@guidezpl
Copy link
Member

When running the gallery, a slew of these errors appear

[intl_zu.arb:craneMinutes] ICU Syntax Warning: The plural part specified below is overridden by a later plural part.
  {minutes,plural, =1{1m}one{{minutes}m}other{{minutes}m}}`

They're not actionable but we should figure out what they are and how to resolve them.

cc @HansMuller who knows about this topic?
@guidezpl guidezpl added bug Something isn't working P1 Priority 1 - Must have labels Feb 10, 2023
@guidezpl
Copy link
Member Author

@thkim1011 can you please take a look?

@thkim1011
Copy link
Contributor

This happens because Google's internal translations distinguish between =1 case and one case whereas ICU doesn't. I'll make a PR adding the suppress-warnings: true flag to l10n.yaml.

@thkim1011 thkim1011 mentioned this issue Feb 13, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@thkim1011 thkim1011

Labels
bug Something isn't working P1 Priority 1 - Must have
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Suppress l10n warnings thkim1011/gallery
2 participants
@thkim1011 @guidezpl