Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

Address null safety exclusions in flutter/gallery #752

Closed
Tracked by #110016
devoncarew opened this issue Aug 22, 2022 · 4 comments · Fixed by #757
Closed
Tracked by #110016

Address null safety exclusions in flutter/gallery #752

devoncarew opened this issue Aug 22, 2022 · 4 comments · Fixed by #757
Assignees

Comments

@devoncarew
Copy link
Member

devoncarew commented Aug 22, 2022

See flutter/flutter#110016 for context.

test_benchmarks/benchmarks/client.dart:1:// @dart=2.9
test_benchmarks/benchmarks/common.dart:1:// @dart=2.9
test_benchmarks/benchmarks/gallery_automator.dart:5:// @dart=2.9
test_benchmarks/benchmarks/gallery_recorder.dart:5:// @dart=2.9
test_benchmarks/benchmarks/project_root_directory.dart:1:// @dart=2.9
test_benchmarks/benchmarks/run_benchmarks.dart:1:// @dart=2.9
test_benchmarks/benchmarks/scroll.dart:5:// @dart=2.9
test_benchmarks/benchmarks_test.dart:1:// @dart=2.9
test_benchmarks/web_bundle_size_test.dart:5:// @dart=2.9
@devoncarew devoncarew changed the title flutter/gallery - 9 exclusions Address null safety exclusions in flutter/gallery Aug 22, 2022
@devoncarew devoncarew transferred this issue from flutter/flutter Aug 22, 2022
@mit-mit
Copy link
Member

mit-mit commented Aug 22, 2022

Hey @guidezpl would it be possible to get this migrated to null safety (i.e. remove the @dart=2.9 language markers)?

@guidezpl
Copy link
Member

@pennzht could you take a look?

@pennzht pennzht self-assigned this Aug 23, 2022
@amanv8060
Copy link
Contributor

this was blocked on package migration ( #527 (comment)). PR for package migration has been merged and new version is available (https://pub.dev/packages/web_benchmarks).
PR for migrating test_benchmarks : #757

@pennzht
Copy link
Member

pennzht commented Sep 5, 2022

Thank you for your message. Taking a look now.

@guidezpl guidezpl linked a pull request Sep 6, 2022 that will close this issue
8 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants