-
Notifications
You must be signed in to change notification settings - Fork 1.6k
a little problem when I tap the demo app #600
Comments
@guidezpl should the mail be unstarred when it is being deleted? |
Was this on the Android app? |
this is on small device size when dismissible is used. Regardless of the error, should the mail be unstarred when it is deleted? |
I don't think so |
@guidezpl I just checked with a couple of mail clients (including Gmail), and emails are unstarred when they are deleted. And from a UX perspective showing a mail in both starred and deleted doesn't make sense to me. Edit: I also noticed that restoring a mail from trash, restores it in starred condition, if it was deleted in that condition. But maybe we can leave it as out of scope for the gallery, or implement it. |
I'll trust the UX folks from Gmail over myself then :) I'm unable to repo the crash error you mentioned in the issue, can you share exactly how you got it? |
missed this.
Mentioned error will be there. |
Hey, I still receive the same error see in attached video [✓] Flutter (Channel master, 3.1.0-0.0.pre.1528, on macOS 12.4 21F79 darwin-arm, locale en-BG) [✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0) [✓] Xcode - develop for iOS and macOS (Xcode 13.3.1) [✓] Chrome - develop for the web [✓] Android Studio (version 2021.2) [✓] Connected device (3 available) [✓] HTTP Host Availability A dismissed Dismissible widget is still part of the tree. 22-07-08-11-22-57.mp4. |
First i starred an email ,then I go to my starred mail。when i try to swipe left the demo item,it crash.
Console log is like that:
======== Exception caught by widgets library =======================================================
The following assertion was thrown building Dismissible-[InboxEmail#69e37](dirty, dependencies: [Directionality], state: _DismissibleState#42939(tickers: tracking 2 tickers)):
A dismissed Dismissible widget is still part of the tree.
Make sure to implement the onDismissed handler and to immediately remove the Dismissible widget from the application once that handler has fired.
My flutter sdk is 2.10.0 , and dart sdk is 2.16.0
The text was updated successfully, but these errors were encountered: