Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable two lint rules which are being removed. #8488

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Disable two lint rules which are being removed. #8488

merged 1 commit into from
Oct 31, 2024

Conversation

srawlins
Copy link
Contributor

Each of these are going to be removed soon.

  • avoid_null_checks_in_equality_operators
  • unsafe_html

Work towards dart-lang/sdk#59514 and dart-lang/sdk#57099

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or there is a reason for not adding tests.

build.yaml badge

If you need help, consider asking for help on Discord.

@srawlins
Disable two lint rules which are being removed.
cfe2bc2 
Each of these are going to be removed soon.

* avoid_null_checks_in_equality_operators
* unsafe_html

Work towards https://github.com/dart-lang/linter/issues/5063 and https://github.com/dart-lang/linter/issues/5001
@srawlins srawlins requested review from kenzieschmoll and a team as code owners October 29, 2024 18:29
@srawlins srawlins mentioned this pull request Nov 15, 2024
Closed
15 tasks
@srawlins srawlins merged commit 80a71da into flutter:master Oct 31, 2024
23 of 24 checks passed
@srawlins srawlins deleted the no-lint-rules branch October 31, 2024 19:11
mossmana pushed a commit to mossmana/devtools that referenced this pull request Oct 31, 2024
@srawlins @mossmana
Disable two lint rules which are being removed. (flutter#8488)
cf84876 
Each of these are going to be removed soon.

* avoid_null_checks_in_equality_operators
* unsafe_html

Work towards https://github.com/dart-lang/linter/issues/5063 and https://github.com/dart-lang/linter/issues/5001
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenzieschmoll kenzieschmoll kenzieschmoll approved these changes

Assignees
No one assigned
Labels
release-notes-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srawlins @kenzieschmoll