Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GC events are reported with wrong units on logging page #7080

Open
DanTup opened this issue Jan 22, 2024 · 1 comment
Open

GC events are reported with wrong units on logging page #7080

DanTup opened this issue Jan 22, 2024 · 1 comment
Labels
bug Something isn't working P2 important to work on, but not at the top of the work list. screen: logging Issues with the Logging screen

Comments

@DanTup
Copy link
Contributor

DanTup commented Jan 22, 2024

See dart-lang/sdk#54692 (comment) - the GC events being shown are reported as ms but are apparently microseconds, not milliseconds.

@DanTup DanTup added bug Something isn't working screen: logging Issues with the Logging screen labels Jan 22, 2024
@elliette elliette added the P2 important to work on, but not at the top of the work list. label Jul 10, 2024
@kenzieschmoll
Copy link
Member

Here is an example GC event we get in the logging page:


  "reason": "idle",
  "new": {
    "type": "HeapSpace",
    "name": "new",
    "vmName": "Scavenger",
    "collections": 257,
    "avgCollectionPeriodMillis": 334489.74241634243,
    "used": 3104,
    "capacity": 524288,
    "external": 224,
    "time": 0.170491
  },
  "old": {
    "type": "HeapSpace",
    "name": "old",
    "vmName": "PageSpace",
    "collections": 30,
    "used": 86273376,
    "capacity": 92065792,
    "external": 21776,
    "time": 0.12025,
    "avgCollectionPeriodMillis": 2865462.1269
  },
  "isolate": {
    "type": "@Isolate",
    "id": "isolates/8828232814957387",
    "name": "main",
    "number": "8828232814957387",
    "isSystemIsolate": false,
    "isolateGroupId": "isolateGroups/3684315914930295"
  }
}

@rmacnak-google in this comment you mentioned that the units are incorrect. What units is the "time" field for the new and old entries in the map above?

We calculate the time as follows:

final time = ((newSpace.time! + oldSpace.time!) * 1000).round();

where newSpace.time and oldSpace.time are the raw double values from the "old" and "new" json entires.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P2 important to work on, but not at the top of the work list. screen: logging Issues with the Logging screen
Projects
None yet
Development

No branches or pull requests

3 participants