Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setting breakpoints doesn't work when devtools is launched from IntelliJ #695

Closed
devoncarew opened this issue May 30, 2019 · 6 comments
Closed

setting breakpoints doesn't work when devtools is launched from IntelliJ #695

devoncarew opened this issue May 30, 2019 · 6 comments
Labels
bug Something isn't working P2 important to work on, but not at the top of the work list. reproduce to verify Issues that need to be reproduced to verify that they still exist. screen: debugger Issues with the Debugger screen
Milestone
0.1.6

Comments

@devoncarew
Copy link
Member

I'm not able to consistently set breakpoints in the debugger page.
@devoncarew devoncarew added the screen: debugger Issues with the Debugger screen label May 30, 2019
@devoncarew
Copy link
Member Author

This seems to happen when you've launched devtools from IntelliJ.

@devoncarew devoncarew changed the title setting breakpoints may have regressed setting breakpoints doesn't work when devtools is launched from IntelliJ Jun 4, 2019
@devoncarew
Copy link
Member Author

I'm having trouble reproing this now.

@devoncarew
Copy link
Member Author

This may happen after a hot restart is performed; the older breakpoints may not be removed, and may still point to the previous scripts (and, new breakpoints for the new scripts are not set).

@devoncarew
Copy link
Member Author

Most of the issues do seem to be related to breakpoints (and other debugger features) not working as well after the app has been restarted. I think after a restart we'll need to re-load the list of scripts (and update this in the UI).

I don't believe we get an event when a script is re-loaded (via hot reload). We get a kPausePostRequest event which we can use to know we have to reload some data.

It could also be useful for the VM to fire an event after a script is reloaded (not for the ~800 initial scripts, but for deltas after an isolate has started). This could be generally useful for tools. cc @bkonyi

@jacob314 jacob314 added the bug Something isn't working label Jun 17, 2019
@jacob314 jacob314 added this to the 0.1.2 milestone Jun 17, 2019
@jacob314
Copy link
Contributor

Set the milestone for this one aggressively to 0.1.2. The issue is indeed hot restart/reload related. We need to re-initialize breakpoints after a restart/reload and there are some tricky edge cases we need to work through when multiple IDEs are connected.

@kenzieschmoll kenzieschmoll modified the milestones: 0.1.2, 0.1.6 Jul 22, 2019
@kenzieschmoll kenzieschmoll added reproduce to verify Issues that need to be reproduced to verify that they still exist. P2 important to work on, but not at the top of the work list. labels Oct 17, 2024
@elliette
Copy link
Member

This was fixed with #7231

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working P2 important to work on, but not at the top of the work list. reproduce to verify Issues that need to be reproduced to verify that they still exist. screen: debugger Issues with the Debugger screen
Projects
None yet
Milestone
0.1.6
Development

No branches or pull requests
4 participants
@jacob314 @devoncarew @elliette @kenzieschmoll