Handle check_run completions with ci staging #4042
Open
+655
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now we have "three" stages: 1. non-monorepo: none (schedule everything) 2. mono-repo: engine, tests. To handle 2-engine, we need to react to updates from check_run events. This PR only cares about flutter/flaux right now, but it will care about any monorepo in the future. The engine check is hard-coded because to put it somewhere else would be to either create a new firestore doc or encode it in the tree (e.g. .ci.yaml) - but we're not interested in building a build-graph right now.
jtmcdole
commented
Nov 23, 2024
| @@ -413,6 +434,22 @@ class Scheduler { | |||
| } | |||
|
|
|||
| // Update validate ci.yaml check | |||
| await closeCiYamlCheckRun(pullRequest, exception, slug, ciValidationCheckRun); | |||
There was a problem hiding this comment.
I think our create/close/lock/unlock could be shared functions.
|
save it for monday @yjbanov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we have "three" stages:
To handle monorepo, we need to react to updates from check_run events.
The engine check is hard-coded because to put it somewhere else would be
to either create a new firestore doc or encode it in the tree (e.g. .ci.yaml) - but
we're not interested in building a build-graph right now.
To reduce the QPH quota; we could cache the check-run id to PR lookup in firestore.