Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flaky issue bot should not override existing priorities #3900

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

flaky issue bot should not override existing priorities #3900

wants to merge 1 commit into from

Conversation

christopherfujino
Copy link
Member

@chunhtai chunhtai requested review from chunhtai and removed request for goderbauer November 12, 2024 23:49
chunhtai
chunhtai reviewed Nov 13, 2024
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I can see the reasoning behind this, but we will risking the serious flake gets ignored due to the owner giving it a low priority.

If the problem is that the bot is too annoying at non critical flake, we can consider raising the threshold or have multiple threshold level for different priority. e.g. >10% is P0, 2%~10% is P1, below 2% is P2. WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunhtai chunhtai chunhtai left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flaky issue bot should not override existing priority labels
2 participants
@christopherfujino @chunhtai