Better canonicalization of GitHub usernames #3698
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -61,6 +61,11 @@ bool issueIsClosed(final FullIssue issue) { | |||
| return issue.metadata.isClosed || issue.metadata.state.toUpperCase() == 'CLOSED'; | |||
| } | |||
|
|
|||
| // Turns a username into an internal canonicalized form. | |||
| // We add a "👤" emoji here so that if we accidentally use the canonicalized form | |||
| // in the output, we will catch it. | |||
There was a problem hiding this comment.
Where do we check for this?
There was a problem hiding this comment.
I just meant we'll notice it in the console.
|
(PR Triage): Hey @Hixie is this still on your radar? Thanks! |
|
It's on my radar but I can't do much unless it's reviewed. :-) |
| // Turns a username into an internal canonicalized form. | ||
| // We add a "👤" emoji here so that if we accidentally use the canonicalized form | ||
| // in the output, we will catch it. | ||
| String canon(final String? s) => '👤${(s ?? "").toLowerCase()}'; |
There was a problem hiding this comment.
when do we pass null to this function?
christopherfujino
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.