Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsonrpc-calls-96 #97

Closed
wants to merge 3 commits into from

Conversation

terrycojones
Copy link
Member

ceronman: approve

Added JSON RPC support.

This took an hour, at the end of which @jkakar showed up in IRC and told me we don't need this in fluidinfo.js at the moment. So we can either merge this and not use it, merge it and start using it, or I can withdraw the pull request and it can be merged at some later date if wanted.

Based on #95

Fixes #96

@jkakar
Copy link
Contributor

jkakar commented May 7, 2012

We could merge this, but it won't replace the jsonrpc function we
have in Fluidinfo because it customizes the onSuccess and onError
handlers so it can return a Deferred (which we need to make easily
make simultaneous network calls). My inclination is to leave this out
until we decide to add support for the comments API to fluidinfo.js
with explicit addComment, getComments, etc. methods.

@ceronman
Copy link
Member

+1. LGTM. Even if fluidinfo.com doesn't use this. It is useful for other clients or users.

@terrycojones
Copy link
Member Author

@ntoll - what's your take on this? Should we merge it or shelve it? I have a slight preference for the former, but don't mind either way.

@ntoll
Copy link
Member

ntoll commented May 19, 2012

I think we should merge when we make the comment API available to the wider world (otherwise there's no point in having it in the library).

@terrycojones
Copy link
Member Author

OK. I'll close the pull request. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for JSON RPC calls
4 participants