Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jobs: hide .mru files #1503

Closed
thijstriemstra opened this issue Oct 8, 2024 · 4 comments · Fixed by #1507
Closed

jobs: hide .mru files #1503

thijstriemstra opened this issue Oct 8, 2024 · 4 comments · Fixed by #1507
Assignees
Labels
FR - Enhancement New feature or request
Milestone

Comments

@thijstriemstra
Copy link
Contributor

Fluidd Version

1.30.4

Browser

Firefox

Device

Desktop PC

Operating System

Windows

What happened

The jobs page has .mru files in it:

afbeelding

I enabled the hidden files filter.

What did you expect to happen

That .mru files are hidden.

How to reproduce

Not sure..!

Additional information

No response

@thijstriemstra thijstriemstra added GH - Bug Something isn't working GH - Evaluation Needed This topic needs to be discussed to evaluate it's aspects and feasability labels Oct 8, 2024
@pedrolamas
Copy link
Member

Hi @thijstriemstra, thanks for opening this ticket.

To be honest, I am a bit skeptical of adding "random" file types or extensions that I don't know of... I assume "mru" here referes to "most recently used", but the question is what actually created these files in the first place? Possibly some app you are using?

@pedrolamas pedrolamas added FR - Enhancement New feature or request and removed GH - Bug Something isn't working labels Oct 10, 2024
@thijstriemstra
Copy link
Contributor Author

my guess is mru stands for moonraker upload? i'll try to search moonraker codebase.

@pedrolamas
Copy link
Member

my guess is mru stands for moonraker upload? i'll try to search moonraker codebase.

Oh, good call!!

https://github.com/Arksine/moonraker/blob/71f9e677b81afcc6b99dd5002f595025c38edc7b/moonraker/components/file_manager/file_manager.py#L810

Given this I think it does make sense to add a new entry to hide these files (as they are created by Moonraker)

@pedrolamas pedrolamas removed the GH - Evaluation Needed This topic needs to be discussed to evaluate it's aspects and feasability label Oct 10, 2024
@pedrolamas pedrolamas added this to the 1.30.5 milestone Oct 10, 2024
@thijstriemstra
Copy link
Contributor Author

my guess is they're unprocessed or failed moonraker uploads? not sure how they ended up in this state though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FR - Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants