Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element overlapping occurs when UIO text size is increased #57

Closed
BlueSlug opened this issue Mar 14, 2022 · 0 comments · Fixed by #76
Closed

Element overlapping occurs when UIO text size is increased #57

BlueSlug opened this issue Mar 14, 2022 · 0 comments · Fixed by #76
Assignees
Labels
accessibility This is an accessibility concern or failure bug Something isn't working

Comments

@BlueSlug
Copy link
Member

Describe the bug

As reported by @cindyli: "Gradually increase UIO font size, you will notice a few issues:

On the desktop view:

  1. At some point, the menu bar at the top right will overlap with the logo at the top left;
  2. Go to a page having the side menu, such as the "Perspectives" page, the main content overflows and stretches out of the screen width. The content in the left panel even gets cut off and loses some content.

On the mobile view:

  1. The menu icon doesn't overlap with the logo but the full width of these two elements exceeds the screen size causing the overflow.
  2. The page title, "Perspectives" in this case, does wrap into multiple lines. But these lines start to overlap on each other.

Instead of using UIO, if you use "Command" and "+" to increase font size, the browser will handle the font change quite nicely: the browser translates the font change to the viewport size change so that when the font size is large enough, the viewport will be switched from the desktop view to the mobile view. UIO doesn't have this ability yet.

WeCount site ran into the same issue. The decision was to remove the text size change from UIO."

To reproduce

Steps to reproduce the behavior:

  1. Go to the Perspectives page: https://handbook.floeproject.org/perspectives/
  2. Click on "show preferences" to open the UIO panel
  3. Increase the text size preference to 2
  4. Reduce the viewport/window width
  5. See error

Expected behavior

Text should not be overlapping itself nor other elements on the page such as the header banner.

Screenshots

157681330-5151064a-2ca5-425b-8c0d-e2017b2b1efc

157681900-3f695dd3-64f3-4025-93bc-af86e8000daa

Technical details

Desktop

  • OS: Windows 10 Pro 21H2
  • Browser & version: Chrome 99

Mobile device

  • Device: Google Pixel 5
  • OS: Android 12
  • Browser & version: Chrome 99

Assistive technology used

N/A

Additional context or notes

As reported in #48 review

@BlueSlug BlueSlug added the bug Something isn't working label Mar 14, 2022
@BlueSlug BlueSlug changed the title Text overlapping occurs when UIO text size is increased Element overlapping occurs when UIO text size is increased Mar 18, 2022
@BlueSlug BlueSlug self-assigned this Mar 18, 2022
@BlueSlug BlueSlug added the accessibility This is an accessibility concern or failure label Mar 18, 2022
@BlueSlug BlueSlug linked a pull request Mar 29, 2022 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility This is an accessibility concern or failure bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant