Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transformer mappings circular dependencies #106

Closed
IlCallo opened this issue Feb 2, 2018 · 2 comments
Closed

Transformer mappings circular dependencies #106

IlCallo opened this issue Feb 2, 2018 · 2 comments

Comments

@IlCallo
Copy link
Contributor

IlCallo commented Feb 2, 2018

Now that it's possible to put mappings on $relations, I tried to add them everywhere.
Then I got stuck into a cicular dependency of those mappings and a segmentation fault happened.

If I remember correctly, Fractal prevents circular dependencies cutting them down after X iterations, but with the new layer of mapping used to eager load relations I guess this behaviour wasn't taken into account.

@flugg
Copy link
Owner

flugg commented Feb 2, 2018

Oh, this makes sense. We’re traversing the transformers recursively, and if two transformers reference each other I suppose it ends up with an endless loop. Can’t believe I didn’t think about this.

I’ll think some how we best can solve this, but it definitely needs fixing ASAP, as this sounds like a very normal use case

@flugg
Copy link
Owner

flugg commented Feb 6, 2018

This is now fixed with v3.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants