Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve all warnings in CI #848

Closed
tagomoris opened this issue Mar 11, 2016 · 4 comments
Closed

Resolve all warnings in CI #848

tagomoris opened this issue Mar 11, 2016 · 4 comments
Labels
enhancement Feature request or improve operations v0.14

Comments

@tagomoris
Copy link
Member

Currently, Fluentd code reports many warnings if it is enabled.
It shows potential errors and troubles in code. So warnings should be resolved basically.

This ticket is blocker for v0.14.0 release.

  1. revert Rakefile: Suppress warnings from ruby, enabled by rake 11 #846
  2. remove all warnings from fluentd's code
  3. remove warnings from dependencies as much as possible
@okkez
Copy link
Contributor

okkez commented Mar 30, 2016

@okkez
Copy link
Contributor

okkez commented Mar 30, 2016

NOTE:

I think we cannot set @timeout from outside of the class.
(I think we can replace @timeout with 0 or initialize @timeout with 0.)


lib/fluent/test/input_test.rb:112: warning: method redefined; discarding old emit_stream
lib/fluent/test/input_test.rb:112: warning: previous definition of emit_stream was here
lib/fluent/test/input_test.rb:115: warning: method redefined; discarding old emit_stream
lib/fluent/test/input_test.rb:115: warning: previous definition of emit_stream was here
lib/fluent/test/input_test.rb:112: warning: method redefined; discarding old emit_stream

@tagomoris
Copy link
Member Author

#966 will solve this problem.

@tagomoris
Copy link
Member Author

After #966, there are no warning shown in running tests. There are still some warnings in loading scripts, but I think it's not serious blocker for the project.
(For other committers: If it's wrong, please reopen this.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request or improve operations v0.14
Projects
None yet
Development

No branches or pull requests

2 participants