Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add size to tell the number of events in a message #1135

Closed
ganmacs opened this issue Aug 1, 2016 · 3 comments
Closed

Add size to tell the number of events in a message #1135

ganmacs opened this issue Aug 1, 2016 · 3 comments
Labels
enhancement Feature request or improve operations v0.14

Comments

@ganmacs
Copy link
Member

ganmacs commented Aug 1, 2016

To tell the number of events, add size key to option in forward protocol.

I think it'll work by adding below task.

  • add size key to option at ForwardOutput#send_data
  • pass the size value to constructor's argument of EventStream at ForwardInput#on_message

ref https://github.com/fluent/fluentd/wiki/Forward-Protocol-Specification-v0

@tagomoris tagomoris added enhancement Feature request or improve operations v0.14 labels Aug 1, 2016
@tagomoris
Copy link
Member

You mean "add size key to option at ForwardOutput#send_data", right?
Currently, EventStream#initialize doesn't have size argument. Will you add it?

@ganmacs
Copy link
Member Author

ganmacs commented Aug 1, 2016

You mean "add size key to option at ForwardOutput#send_data", right?

Yes, i'll fix it.

Currently, EventStream#initialize doesn't have size argument. Will you add it?

Sorry, i was wrong.
MessagePackEventStream and MultiEventStream require adding size argument.
And MessagePackEventStream already has size argument.
So i'll add size argument to MultiEventStream#initialize like below

def initialize(time_array = [], record_array = [], size = time_arrry.size)
 ...
end

@tagomoris
Copy link
Member

@ganmacs Okay, got it. Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request or improve operations v0.14
Projects
None yet
Development

No branches or pull requests

2 participants