Incorrect boolean configuration for TLS and cloudwatch.

[patrick-stephens]

Bug Report

Describe the bug

Boolean configuration should be using the standard utility method to handle:

• yes/no
• on/off
• true/false

And all case variants of it.
See:

fluent-bit/src/flb_utils.c

Lines 659 to 673 in bbc520a

	int flb_utils_bool(const char *val)
	{
	if (strcasecmp(val, "true") == 0 ||
	strcasecmp(val, "on") == 0 ||
	strcasecmp(val, "yes") == 0) {
	return FLB_TRUE;
	}
	else if (strcasecmp(val, "false") == 0 ||
	strcasecmp(val, "off") == 0 ||
	strcasecmp(val, "no") == 0) {
	return FLB_FALSE;
	}
	return -1;
	}

Unfortunately it looks like TLS configuration for input and output, as well as Cloudwatch configuration, does not use this method and rolls it's own that does not support the yes/no values:

• fluent-bit/src/flb_output.c

  Line 863 in bbc520a

  if (strcasecmp(tmp, "true") == 0 || strcasecmp(tmp, "on") == 0) {

• fluent-bit/plugins/out_cloudwatch_logs/cloudwatch_logs.c

  Lines 187 to 189 in bbc520a

  	tmp = flb_output_get_property("auto_create_group", ins);
  	/* native plugins use On/Off as bool, the old Go plugin used true/false */
  	if (tmp && (strcasecmp(tmp, "On") == 0 || strcasecmp(tmp, "true") == 0)) {

• fluent-bit/src/flb_input.c

  Line 544 in bbc520a

  if (strcasecmp(tmp, "true") == 0 || strcasecmp(tmp, "on") == 0) {

This means if someone uses yes/no to configure TLS it will lead to an invalid configuration.

To Reproduce

• Rubular link if applicable:
• Example log message if applicable:

{"log":"YOUR LOG MESSAGE HERE","stream":"stdout","time":"2018-06-11T14:37:30.681701731Z"}

• Steps to reproduce the problem:

Expected behavior

yes/no can be used to confgure TLS and Amazon Cloudwatch.

Screenshots

Your Environment

• Version used:
• Configuration:
• Environment name and version (e.g. Kubernetes? What version?):
• Server type and version:
• Operating System and version:
• Filters and plugins:

Additional context