Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.1.4 reporting as 2.1.3 #7473

Closed
patrick-stephens opened this issue May 25, 2023 · 6 comments
Closed

2.1.4 reporting as 2.1.3 #7473

patrick-stephens opened this issue May 25, 2023 · 6 comments
Assignees

Comments

@patrick-stephens
Copy link
Contributor

Bug Report

The CMakeLists.txt version was not updated for the 2.1.4 release which means all packages, not containers though, are built for a 2.1.3 version and naming. This then means they have overwritten the previous 2.1.3 binaries in the repositories.

We need a check for this in the pre-release phase and/or move to using the tag during release for CMake rather than hardcoded values.

To resolve:

  1. Rebuild the 2.1.3 release and trigger it so it re-uploads and overwrites the 2.1.4 binaries of the same name.
  2. If we want to keep 2.1.4: update CMakeLists.txt to 2.1.4, move the 2.1.4 tag after 2.1.3 release is complete to trigger a new build.
  3. Otherwise move to 2.1.5 and indicate not to use 2.1.5
@patrick-stephens
Copy link
Contributor Author

Triggered re-run of 2.1.3 build: https://github.com/fluent/fluent-bit/actions/runs/5005546281

@patrick-stephens
Copy link
Contributor Author

Sanity check to prevent future issues added as part of #7474

@patrick-stephens
Copy link
Contributor Author

Containers are tagged correctly but internally report 2.1.3, notice the delta in the git commit and digest though:

$ docker run --pull=always --rm -it fluent/fluent-bit:2.1.4 --version
2.1.4: Pulling from fluent/fluent-bit
Digest: sha256:4224257945e6e4442f9a9d6f5387dbfec6d8364b104298b5406bd5456acb7c7b
Status: Downloaded newer image for fluent/fluent-bit:2.1.4
Fluent Bit v2.1.3
Git commit: 3446ace89ba6057f7a8ed5685d970eae1bb86cbb
$ docker run --pull=always --rm -it fluent/fluent-bit:2.1.3 --version
2.1.3: Pulling from fluent/fluent-bit
Digest: sha256:66721b4192dc23343734c078f80d9962c2efd9e4df94b525ddc3c5799de40ecd
Status: Image is up to date for fluent/fluent-bit:2.1.3
Fluent Bit v2.1.3
Git commit: a7026aa82eb41bf92b7ca2e61cca1698def62ce0

@patrick-stephens
Copy link
Contributor Author

patrick-stephens commented May 25, 2023

Triggering re-release of 2.1.3: https://github.com/fluent/fluent-bit/actions/runs/5079276952
Unfortunately it looks like the appveyor build has disappeared from the history or is too far back to be picked up for now. As we do not need it in this case (appveyor failed for 2.1.4 anyway as the release name did not match) re-triggering using the v2.1.3 tag for the workflow: https://github.com/fluent/fluent-bit/actions/runs/5079334571

2.1.3 binaries should now be based on the 2.1.3 tag.

@patrick-stephens
Copy link
Contributor Author

@edsiper the question now is what to do about 2.1.4. Either we move the tag or just skip to 2.1.5 which might be better.

@patrick-stephens patrick-stephens changed the title 2.1.4 release has overwritten 2.1.3 binaries 2.1.4 reporting as 2.1.3 May 25, 2023
@patrick-stephens
Copy link
Contributor Author

Tag moved and retriggered release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants