Fixed storage.total_limit_size misleading document content #1244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ErMao <[email protected]>
lecaros
requested changes
Oct 23, 2023
| @@ -191,5 +191,5 @@ The following example create records with CPU usage samples in the filesystem an | |||
| storage.total_limit_size 5M | |||
| ``` | |||
|
|
|||
| If for some reason Fluent Bit gets offline because of a network issue, it will continue buffering CPU samples but just keep a maximum of 5M of the newest data. | |||
| If for some reason Fluent Bit gets offline because of a network issue, it will continue buffering CPU samples but just keep a maximum of 5M bytes of the newest data. | |||
There was a problem hiding this comment.
please make the unit one word, i.e., MB or Megabytes
There was a problem hiding this comment.
i have modified it
Signed-off-by: ErMao <[email protected]>
|
Hi @lecaros |
lecaros
approved these changes
Dec 18, 2023
|
Merged! Thanks for your contribution @opencmit2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed storage.total_limit_size misleading document content