feat(metrics): add chain info metrics #2386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folex
reviewed
Sep 23, 2024
folex
reviewed
Sep 23, 2024
crates/peer-metrics/src/info.rs
Outdated
| use prometheus_client::metrics::info::Info; | ||
| use prometheus_client::registry::Registry; | ||
|
|
||
| pub struct NoxInfo { | ||
| pub versions: NoxVersions, |
There was a problem hiding this comment.
Why? NoxVersions implement the EncodeLabelSet which creates the array automatically from the structure fields and values
folex
reviewed
Sep 23, 2024
crates/peer-metrics/src/info.rs
Outdated
| } | ||
|
|
||
| impl ChainInfo { | ||
| pub fn empty(peer_id: String) -> ChainInfo { |
There was a problem hiding this comment.
Well, maybe. I would expect that default is what implements Default, and I'm not sure if this thing should implement default, but whatever
There was a problem hiding this comment.
I think it's a good idea to move empty to Default implementation, that's the rust way of things
folex
reviewed
Sep 23, 2024
crates/peer-metrics/src/info.rs
Outdated
| sub_registry.register("chain", "Chain Nox Info", chain_info); | ||
| } | ||
|
|
||
| pub fn add_info_metrics2( |
There was a problem hiding this comment.
Oh yeah, forgot the remove
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a chain info metric with chain configuration
Proposed Changes
server-configdependency onpeer-metrics. It turned out to be useless in this PR, but maybe will be helpful in the next one with more configscurrent_commitment_status. The status is a number which corresponds to the CCStatus enum in chain_listener.nox_chain_infometric. Example: