Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler): Refactor header semantics [LNG-352] #1113

Merged
merged 30 commits into from
Apr 9, 2024
Merged

fix(compiler): Refactor header semantics [LNG-352] #1113

merged 30 commits into from
Apr 9, 2024

Conversation

InversionSpaces
Copy link
Contributor

@InversionSpaces InversionSpaces commented Apr 2, 2024 •
edited by DieMyst
Loading

Description

Refactor HeaderSem, removing unnecessary code and simplifying it.

Proposed Changes

  • Simplify HeaderSem
  • Refactor RawContext
  • Refactor RawSemantics

Checklist

  • Corresponding issue has been created and linked in PR title.
  • Proposed changes are covered by tests.
  • Documentation has been updated to reflect the changes (if applicable).
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

@linear Linear
Copy link

linear bot commented Apr 2, 2024

LNG-352 Refactoring HeaderHandler and headers semantic

@InversionSpaces InversionSpaces marked this pull request as draft April 2, 2024 15:35
@InversionSpaces InversionSpaces added e2e Run e2e workflow and removed e2e Run e2e workflow labels Apr 8, 2024
@InversionSpaces InversionSpaces added e2e Run e2e workflow and removed e2e Run e2e workflow labels Apr 8, 2024
@InversionSpaces InversionSpaces added the e2e Run e2e workflow label Apr 8, 2024
@InversionSpaces InversionSpaces marked this pull request as ready for review April 9, 2024 09:40
@InversionSpaces InversionSpaces requested a review from DieMyst April 9, 2024 09:40
@InversionSpaces InversionSpaces merged commit f29e44e into main Apr 9, 2024
17 of 25 checks passed
@InversionSpaces InversionSpaces deleted the fix/LNG-352-refactor-header-sem branch April 9, 2024 10:58
@fluencebot fluencebot mentioned this pull request Apr 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DieMyst DieMyst DieMyst approved these changes

Assignees
No one assigned
Labels
e2e Run e2e workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@InversionSpaces @DieMyst