fix(compiler): Redeclare imports [LNG-344] #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| else | ||
| else { | ||
| // summarize contexts to allow redeclaration of imports | ||
| val sumCtx = ctx |+| initCtx |
There was a problem hiding this comment.
I guess it is more reasonable to do initCtx |+| ctx? Operation is not commutative and logically initCtx goes before ctx. WDYT?
| @@ -30,16 +31,18 @@ class ModuleSem[S[_]: Comonad, C: Picker](expr: ModuleExpr[S])(using | |||
| name.value, | |||
| shouldDeclare | |||
| ), | |||
| (ctx, _) => | |||
| (ctx, initCtx) => | |||
| // When file is handled, check that all the declarations exists | |||
| if (declareAll.nonEmpty) | |||
There was a problem hiding this comment.
What about declares all case? Is not the same logic needed here?
aqua Lib declares *
import f from "..."
import g from "..."
seems like a valid use case
InversionSpaces
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow to redeclare imports to make aqua files that have only imports/declarations/exports
Checklist
Reviewer Checklist