Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues in examples #16

Closed
pmli opened this issue Feb 11, 2022 · 2 comments
Closed

Issues in examples #16

pmli opened this issue Feb 11, 2022 · 2 comments

Comments

@pmli
Copy link

pmli commented Feb 11, 2022

  • examples/1_basic_tutorial.ipynb:
    • I got x.shape == (400,) instead of x.shape == (401,)
    • in section 1.2 Finite Difference: Second Order, I suppose that second_order should be called instead of first_order
  • examples/2a_optimizing_parameters_with_dxdt_known.ipynb:
    • same issue with simdt as in Issues when running tests #13
    • removing simdt and replacing dt = 0.1 by dt = 0.01 makes things work, but the generated data looks very different compared to the pre-generated figures
    • similar issue with 1.2 Finite Difference: Second Order as above
  • examples/2b_optimizing_parameters_with_dxdt_unknown.ipynb:
    • similar issues as for the 2a example

(This is related to my JOSS review: openjournals/joss-reviews#4078)

@florisvb
Copy link
Owner

all issues fixed in latest push.

@pmli
Copy link
Author

pmli commented Feb 25, 2022

There is an issue in the first example (it runs fine on my machine):

example1_issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants