Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Content-Type: application/msgpack header #14

Open
astephon88 opened this issue Aug 26, 2021 · 3 comments
Open

Support for Content-Type: application/msgpack header #14

astephon88 opened this issue Aug 26, 2021 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@astephon88
Copy link

astephon88 commented Aug 26, 2021

As evidenced by msgpack/msgpack#194, there still is no clear answer on the "proper" MIME type for msgpack. Fluent-bit's HTTP output plugin uses application/msgpack for the content-type instead of aapplication/x-msgpack, so the msgpack-asgi middleware doesn't attempt to unpack requests from fluent-bit POST's

@astephon88 astephon88 changed the title Supoort for Content-Type: application/msgpack header Support for Content-Type: application/msgpack header Aug 26, 2021
@astephon88
Copy link
Author

@florimondmanca
Copy link
Owner

👍 Sounds like a fair improvement to welcome in here. Might be worth an update to the README too if we're already discussing content types there.

@florimondmanca florimondmanca added good first issue Good for newcomers enhancement New feature or request labels Aug 27, 2021
@astephon88
Copy link
Author

Just an update as I've done a bit more research...I still believe supporting both content types would be a useful improvement, but data coming from fluent-bit still will be problematic. The msgpack messages they are sending is list of a timestamp and a dict. The timestamp is a msgpack ExtType, so, barring some extra logic to only extract JSON compatible data (which probably would be out of place here), the fluent-bit messages would still fail to parse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants